Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precise contributing docs, especially "opens" flag requirements; add 9 games; fix typos #78

Merged
merged 32 commits into from
Sep 24, 2024

Conversation

mattmaniak
Copy link
Member

@mattmaniak mattmaniak commented Aug 23, 2024

Duplicate of #59 as the original PR has been force reset on my local repo accidentally. Deus Ex: Human Revolution is already merged #71. Fixed typos/added more formatting consistency in already added games.

@mattmaniak mattmaniak changed the title Add 5 games; Precise contributing docs, especially "opens" flag requirements; fix typos - separate branch Precise contributing docs, especially "opens" flag requirements; add 8 games; fix typos Aug 31, 2024
@mattmaniak
Copy link
Member Author

Added also:

  • Sniper: Ghost Warrior 3;
  • Sherlock Holmes: The Devil's Daughter;
  • Sherlock Holmes Chapter One.

@mattmaniak mattmaniak changed the title Precise contributing docs, especially "opens" flag requirements; add 8 games; fix typos Precise contributing docs, especially "opens" flag requirements; add 9 games; fix typos Sep 8, 2024
@mattmaniak
Copy link
Member Author

Sniper Ghost Warrior Contracts has been added.

@mattmaniak mattmaniak added the addition New game addition to the docs label Sep 23, 2024
@JoshuaBrest
Copy link
Contributor

JoshuaBrest commented Sep 24, 2024

Can you split this commit up? It's not fun to review big commits.
Generally, you can have multiple branches and PRs.

@mattmaniak
Copy link
Member Author

Sure, will do.

@mattmaniak mattmaniak mentioned this pull request Sep 24, 2024
@mattmaniak
Copy link
Member Author

mattmaniak commented Sep 24, 2024

@JoshuaBrest I made #95 for adding games only. I will keep this PR for comparison purposes before I split it to unique PRs.

@hahayupgit hahayupgit merged commit 993765d into Whisky-App:main Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition New game addition to the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants